Comments

• zawistol Members

  June 2010

  Hi,
  I have found another problem, that is related to this. I am using rel. 20100321.
  
  The following construction doesnt work

  _setSelected(_select("locType1"), DecodeGeoType($Hashcode); 
  function DecodeGeoType($Hashcode){
  if ($Hashcode== "N"){
      return "Nation";
    }
  if ($Hashcode== "C"){
      return "City";
    }
  }
  

  
  
  To make it work, you need to add following line before

  var $var1= DecodeGeoType($Hashcode);
  

  and use $var1 instead of direct function call
  
  
  Lech
• narayan Administrators

  June 2010

  Hi Lech,
  
  There were quite a few changes from Sahi V1 to V3. One of the main things was moving execution away from the browser and into the proxy. This helped solve a lot of issues with loops, ifs etc. but made the older scripts incompatible with the newer Sahi.
  
  
  To explain the behaviour:
  
  Your code:

  function UniqueNumber(){
      var UniqueNumberLocal = Math.floor(Math.random()*9999999);
      return UniqueNumberLocal;
  }
  _setGlobal("GlobalContractName","C25 " + UniqueNumber());
  

  
  
  function UniqueNumber is defined in Rhino's runtime running inside the proxy. _setGlobal("GlobalContractName","C25 " + UniqueNumber()); is converted to a string
  '_setGlobal("GlobalContractName","C25 " + UniqueNumber());' and 'eval'ed on the browser (This happens for all Browser Action APIs). So UniqueNumber would not be found on the browser, and hence fail. Math.random is inbuilt in JS, so is available both on the proxy and the browser.
  
  
  _setGlobal is no longer required in V3. You can just use regular variables.
  Eg.
  

  function UniqueNumber(){
      var UniqueNumberLocal = Math.floor(Math.random()*9999999);
      return UniqueNumberLocal;
  }
  $GlobalContractName = "C25 " + UniqueNumber();
  

  
  
  
  The same thing happens with
  

  _setSelected(_select("locType1"), DecodeGeoType($Hashcode)); 
  function DecodeGeoType($Hashcode){
  if ($Hashcode== "N"){
      return "Nation";
    }
  if ($Hashcode== "C"){
      return "City";
    }
  }
  

  
  String '_setSelected(_select("locType1"), DecodeGeoType($Hashcode);' will be 'eval'ed on the browser and DecodeGeoType will not be found. There are two solutions to this.
  
  do
  

  var $var1= DecodeGeoType($Hashcode);
  _setSelected(_select("locType1"), $var1); 
  

  
  or define the function within < browser > tags, in which case, the function will be made available on the browser rather than in the proxy.
  

  <browser>
  function DecodeGeoType($Hashcode){
  if ($Hashcode== "N"){
      return "Nation";
    }
  if ($Hashcode== "C"){
      return "City";
    }
  }
  </browser>
  
  _setSelected(_select("locType1"), DecodeGeoType($Hashcode));
  

  
  
  Prefixing a $ basically makes values of proxy side variables available to the browser. so
  
  $x = "abc";
  _alert($x);
  
  will become
  
  evalOnBrowser("_alert(" + $x + ")"); (with the required quotes around $x)
  
  You can use $ as a start of a function also, for example, you could do
  

  _setSelected(_select("locType1"), $DecodeGeoType($Hashcode)); 
  function $DecodeGeoType($Hashcode){
  if ($Hashcode== "N"){
      return "Nation";
    }
  if ($Hashcode== "C"){
      return "City";
    }
  }
  

  
  This will become
  evalOnBrowser('_setSelected(_select("locType1"), ' + $DecodeGeoType($Hashcode) + ');')
  
  
  Hope that helps.
  Regards,
  Narayan
• zawistol Members

  June 2010

  Narayan,
  Using $myfunction($param) instead of myfunction($param),
  both for function declaration and invocation
  works perfectly for me in SAHI V3
  Great thanks!
  Lech